fromthepage icon indicating copy to clipboard operation
fromthepage copied to clipboard

Owner summary reporting inaccurate

Open saracarl opened this issue 2 years ago • 4 comments

LVA Reports:

I have one volunteer who is insisting that she completed time that is not captured in her active minutes export on Aug. 15. If you can please take a look at the attached and let me know if you see anything I have missed, that would be very appreciated. All her work is in LVA collections and should be visible to me/ recorded and exported. Also, is the FTP clock on GMT? She insists that all her volunteer time was done on the 15th. I'm not sure there's anything more to uncover, but promised to contact the FTP developers with this issue.

This same volunteer had previously completed several volunteer hours remotely and not had any issue with the amount of time that was recorded for her. I advised her to save more frequently to ensure that the window/browser tab remains active or join us at an event to ensure that she receives "full credit."

Let me know if have any insights into time from this volunteer or advice I can pass along to her.

image

image

saracarl avatar Sep 20 '22 14:09 saracarl

I'd be frustrated, too, if I was the volunteer and felt like I was being shorted. I've investigated this and here's what I found:

If I use the owner dashboard -> summary tab I get the same numbers as you show. BUT.... If I got into the Virginia Untold: Free Registers (Indexing) collection and pull the stats from the collaborators there, I show a lot more time -- 4 hours 42 minutes. I dug into the collection level data some more:

  1. Yes, we track time in GMT, which is 4 hours earlier than EST, so if you work over a date line the time logged will roll into the next day.
  2. I pulled the "Export Activity as CSV" from the collaborators tab for Aug 15-17. (To reproduce, click the button right above "Active Collaborators" here) and then I pulled just Lois's activity out of it and translated (manually!) the GMT times into EST times: image

Based on that, she definitely worked over the date line on the night of 8/15. Based on these activity stamps, she should have close to 4 hours (7:07-10:03, plus the time it took her to do the first actual transcription, which looks like it was taking her ~40 minute per page). 3) Sanity checked that against her time in the "active collaborators" table: image (1)

282 minutes is 4 hours 42 minutes, which is inline with, though slightly higher than, my guesstimate.

There is obviously a bug in the owner dashboard -> summary reporting. We're investigating and will get that fixed.

Thanks for raising this.

saracarl avatar Sep 20 '22 15:09 saracarl

This is the partial that is called from the owner summary; it uses an activity hash for the data: https://github.com/benwbrum/fromthepage/blob/fb125e13ba0c816036ed2b931e7a653194ff7267/app/views/statistics/_collaborator_time.slim#L27 Here is where we set up that activity for the owner summary: https://github.com/benwbrum/fromthepage/blob/main/app/controllers/dashboard_controller.rb#L109 it's all coming from the ahoy summary.

Whereas the contributors tab https://github.com/benwbrum/fromthepage/blob/main/app/views/collection/_contributors_body.html.slim is passing an @stats to recent_statistics which comes from here: https://github.com/benwbrum/fromthepage/blob/4fe18a3b14ceace5458e394db8151f3b3ef87b32/app/models/collection_statistic.rb#L54 and is based entirely on deeds.

saracarl avatar Sep 20 '22 15:09 saracarl

Which one of these do we think is more accurate?

benwbrum avatar Sep 20 '22 15:09 benwbrum

The deed based one, absolutely. We should refactor the owner summary.

saracarl avatar Sep 20 '22 15:09 saracarl