fromthepage icon indicating copy to clipboard operation
fromthepage copied to clipboard

Buttons have auto-width but the inputs they are on have fixed width

Open sylvieed opened this issue 2 years ago • 0 comments

In https://github.com/benwbrum/fromthepage/pull/3169/commits/07bfc451511e3a8cfb57042cae28a7a00519db88 we changed some buttons (i.e. see below) that previously had fixed width to have dynamic/automatic width so that when the locale was changed & the button's text changed length, the text would still fit inside the button.

search search french

However, the input fields these buttons are next to still have fixed width. This causes:

  • The button and input's borders to overlap a bit if the button's text is longer than the previous fixed width (like with a French locale)
search overlap
  • The button and input to be separated a tiny bit with empty space with an English locale for some buttons english gap

  • The button and input to be separated with empty space if the button's text is shorter than the previous fixed width (this doesn't happen with any of our current translations, but it could in the future)

too short

sylvieed avatar Aug 03 '22 21:08 sylvieed