counterscale icon indicating copy to clipboard operation
counterscale copied to clipboard

Add dark mode

Open qwtel opened this issue 1 year ago • 6 comments

Added dark mode based on the (wip?) support that was already part of the repo.

Tweaked the colors a bit based on my own taste.

Added missing dark mode support to the chart, bars and some other places.

There is no toggle, it just follows prefers-color-scheme.

Also includes an inverted version of the counterscale graphic for the landing page.

Screenshot:

Screenshot 2024-08-28 at 16 53 35

qwtel avatar Aug 28 '24 09:08 qwtel

This is awesome!

benvinegar avatar Aug 28 '24 14:08 benvinegar

Apologies for the slow response – I'd like an opportunity to just play with this and do some testing before merging.

benvinegar avatar Sep 05 '24 03:09 benvinegar

No worries, I mostly just wanted this to be visible to someone searching for dark mode.

Btw, I have more improvements on my fork that includes a proper app icon, webapp manifest, and marks many elements as sticky, giving the dashboard a more app-like feel.

Taken together, it makes "Add to Dock" / "Install app" work which gives a native-ish app that looks like this:

Screenshot 2024-09-05 at 15 51 46

qwtel avatar Sep 05 '24 08:09 qwtel

Taken together, it makes "Add to Dock" / "Install app" work which gives a native-ish app that looks like this:

Very cool.


I think my only hesitation on the PR right now is that this applies site-wide, including the landing page, and I don't think this is the look I want to go for.

image

I'm also not sure if I'm capable of maintaining a second "dark" look site-wide that people auto-opt into.

What if we (or I) just added a dark mode toggle in the corner? And we just remember the setting in a cookie.

benvinegar avatar Sep 07 '24 13:09 benvinegar

The Dark Reader extension suggests a colour scheme that closely matches the current one https://imgur.com/a/qmFuJr1

lrh11099 avatar Oct 23 '24 15:10 lrh11099

@qwtel btw do you have your fork deployed somewhere? I'm curious to try the other enhancements.

(Haven't forgotten about this PR.)

benvinegar avatar Dec 28 '24 18:12 benvinegar

We're working on this via a different approach, so closing this

stordahl avatar Nov 18 '25 13:11 stordahl