Ben Vanik

Results 416 comments of Ben Vanik

good q - IMO we only need one, and the more sane behavior (maxnumf/minnumf) seems ideal

Folding is best whenever possible - the reshape/cast ops are only there to carry metadata and should be aggressively removed when the metadata they carry is not useful. For example,...

Related to #18694 and #19348 - it looks like a nice implementation and could be a good starter project for someone to pick up and land.

(I think rebasing/tests may be it? unless this was never run :)

Yuck - that is not a cheap thing to do and has a high risk of flakes - I am still not sure why proper documentation is insufficient? You *must*...

Note that this is also what clang does - https://clang.llvm.org/docs/HIPSupport.html - you *must* pass `--offload-arch=` to compile HIP code and if you want the native host target you must pass...

(if there's such a big concern about documentation not fixing this issue then I'd be ok with making compilation fail if the user doesn't specify an arch for a backend...

That's insanity - besides the debug flags (dumping statistics/etc) if any of those are required that's a bug. I think Mahesh has said it before: a feature is not done...

The CPU flags mirror LLVM - we can't remove them, but we could more intelligently populate them - maybe - triple is often not enough. I think we do ask...

You're unfortunately finding the results of engineers not caring about anything but the exact configuration they are looking at in the moment they author something. Has been an issue for...