leabra icon indicating copy to clipboard operation
leabra copied to clipboard

Can not include Leabra as dependency because it is not on pypi

Open dillontsmith opened this issue 5 years ago • 2 comments

Hello,

the PsyNeuLink modeling library uses the Leabra package in a part of our codebase, but we're unable to include it in our requirements.txt file because pypi requires that all of a package's dependencies be uploaded to pypi themselves (i.e. it does not allow for direct dependencies).

Currently, we check to see if a user has the package installed when they attempt to instantiate a LeabraMechanism. If it's not installed, we raise an error that points them to your git repo for installation.

Naturally, a more elegant solution would be to simply include the Leabra package in our requirements, so that it would be automatically installed like our other dependencies via pip. Given this issue, It would be very convenient for us if leabra were uploaded to pypi, if it is possible and practical for you to do so.

Thank you.

dillontsmith avatar Nov 16 '20 20:11 dillontsmith

I'm not sure if @benureau is in a position to maintain this package. You might want to just fork this into your own repo and do the pypi thing directly.

meanwhile, at some point, we should talk about how to integrate the new Go-based version of leabra into PNL, as it is considerably faster and actively supported. https://github.com/emer/leabra

rcoreilly avatar Nov 16 '20 21:11 rcoreilly

Hi @rcoreilly, thanks for the followup. For now, we'll fork the repo and upload it to pypi as you suggested. As for taking steps towards migrating the dependency to the Go implementation, we are going to have one of our devs (@jeremyrl7) begin to look into that.

dillontsmith avatar Nov 23 '20 14:11 dillontsmith