BentoML icon indicating copy to clipboard operation
BentoML copied to clipboard

EXPERIMENTAL[grpc]: synonymous configuration fields

Open aarnphm opened this issue 3 years ago • 2 comments

Address #2986

This PR address some tests followup as well as some configuration refactor to be consistent with correct exporter field

This PR will also introduce tests related to gRPC tracing interceptor

Depends on #2808 and will rebase to main once #2808 is merged.

aarnphm avatar Sep 12 '22 04:09 aarnphm

Hello @aarnphm, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! :beers:

Comment last updated at 2022-09-13 11:54:03 UTC

pep8speaks avatar Sep 12 '22 04:09 pep8speaks

Codecov Report

Merging #2980 (df37888) into main (926b613) will decrease coverage by 0.01%. The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
- Coverage   67.96%   67.94%   -0.02%     
==========================================
  Files         113      113              
  Lines       10887    10919      +32     
  Branches     1908     1947      +39     
==========================================
+ Hits         7399     7419      +20     
- Misses       3047     3062      +15     
+ Partials      441      438       -3     
Impacted Files Coverage Δ
bentoml/_internal/configuration/containers.py 74.21% <63.63%> (+1.77%) :arrow_up:
bentoml/grpc/interceptors/access.py 93.02% <0.00%> (-2.33%) :arrow_down:
bentoml/grpc/interceptors/prometheus.py 94.23% <0.00%> (-1.93%) :arrow_down:
bentoml/grpc/interceptors/opentelemetry.py 76.11% <0.00%> (-1.50%) :arrow_down:
bentoml/_internal/utils/analytics/usage_stats.py 94.62% <0.00%> (-1.08%) :arrow_down:
bentoml/_internal/utils/__init__.py 67.28% <0.00%> (-0.75%) :arrow_down:
bentoml/_internal/service/loader.py 72.59% <0.00%> (-0.75%) :arrow_down:
bentoml/_internal/utils/telemetry.py 84.00% <0.00%> (-0.62%) :arrow_down:
bentoml/_internal/bento/pip_pkg.py 0.00% <0.00%> (ø)
bentoml/_internal/utils/benchmark.py 0.00% <0.00%> (ø)
... and 3 more

codecov[bot] avatar Sep 12 '22 04:09 codecov[bot]