benthecarman

Results 296 comments of benthecarman

cc @apoelstra @kallewoof if you guys could give some review would appriecate it

> Did a cursory look-over and it looks reasonable. If you could make test vectors I'll see about getting Bitcoin Core RPC variants in place. Made some test vectors, LMK...

todo: test against https://github.com/bitcoin/bitcoin/pull/24058

Yes my opinion is that the DLC Accounting should take into account successful DLCs, I would not call a refunded DLC and it should be treated as if it never...

This would break the wallet. We don't process every block when using neutrino, we only process blocks with filter matches.

todo: fix postgres migrations

It'd be nice to have full api coverage. It probably makes sense to make it a separate library that bdk relies on

> Hey @benthecarman, are you still working on this? May I continue your work? Feel free to!

Here is my PGP signature of the address: ``` -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 bc1q84n390t8eg70gxfnpz5kk7gg7njs7d95900hhd30ll28jw3q0h3sz2t3h3 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEECtg4d8HwzR7pvWYK18x3C4H9IqgFAmE9DDcACgkQ18x3C4H9 IqjVrgv6A37To/AkHJpSvUXqAc6nwpIGi+4hAS/ZXUyS+Yd/iTd0Xo41uVLyRglc 8rKK/AAOW+i5znjVG33rK79bPqwe9idRE2ir27z8byHH4Vr/Rce1Jikl8araMSBx sXbzRSnxZYnFp4CFutRxFIM6+pMsMceaoJqYKhwbwzO7KI37LR3+IS9/y4aORpua VaikPRld5gGbiu1I2wYIhuLBRMl+0o5b5CLP9ODVJpT/fUHETM+FtY+3vXvLd462 /Km5h8PggJLBCsgsNs9V9QbvBlAbtjPYUy9gn2KxjF++oRnOiUkhcT4fqqHjq9/l ackaljcBHPgah/na2aCCGf7LjoxHVT/oQYoIHnXdpPSoY8X2D0zst0B1PZ1qDFXY GHRpfFP7aWUxOb/Jtn03s/MLuoRdG2oHaOlU4xIcRE3bbq2xw2Kj4TGFMqt6X78L xfCY0OWW7LzvmcyhtHxxhtotCBqwZlm7NlsSpLasq7KArrkefGPSj+NmYBqDGGDx Xywdbj7W =yJod...