better-react-spinkit icon indicating copy to clipboard operation
better-react-spinkit copied to clipboard

Published 20 hours ago • verified publisher icon bentatum

Update to React 16 and remove prop-types from peer dependency

Open gforge opened this issue 7 years ago • 3 comments

I'm getting warnings from yarn as below:

warning "[email protected]" has unmet peer dependency "prop-types@^15.5.8".
warning "[email protected]" has incorrect peer dependency "react@^15.5.4".

Would be nice if the package was updated to React 16

gforge avatar Oct 28 '17 21:10 gforge

Any progress on this so far?

kunokdev avatar Nov 15 '17 19:11 kunokdev

I've made a pull request for this https://github.com/bentatum/better-react-spinkit/pull/24

findoo avatar Dec 06 '17 13:12 findoo

I'm still getting a warning for prop-types and lodash. screen shot 2018-02-20 at 5 44 13 pm

@bentatum Think it's a yarn issue. as detailed in the issues below https://github.com/yarnpkg/yarn/issues/4743 https://github.com/yarnpkg/yarn/issues/4969

If i try with NPM all is well.

soorajvnair avatar Feb 20 '18 12:02 soorajvnair