doo icon indicating copy to clipboard operation
doo copied to clipboard

Make sure exit code is zero on unhandled promise rejection in node

Open arichiardi opened this issue 6 years ago • 1 comments

Hello @bensu and all!

I know this is controversial and I can handle it myself in my side of the code but I was wondering whether it makes sense to adopt the following solution by default for :node targets in case of unhandled promise rejection.

https://medium.com/@dtinth/making-unhandled-promise-rejections-crash-the-node-js-process-ffc27cfcc9dd

Leaving this here for further discussion.

arichiardi avatar Jul 05 '18 22:07 arichiardi

+1, although @arichiardi I think you mean "non-zero", correct?

We got hit by this. Builds were passing in Jenkins despite the tests actually failing.

Lambeaux avatar Aug 30 '21 22:08 Lambeaux