Ben Sheldon [he/him]
Ben Sheldon [he/him]
Using the `+` when defining `GOOD_JOB_QUEUES` seems to have some significant performance problems, as uncovered here: https://github.com/bensheldon/good_job/discussions/1091 This feature was introduced here: https://github.com/bensheldon/good_job/pull/665 ...and I don't think we did any...
GoodJob's mountable dashboard requires Rack middleware that usually isn't present on API-only applications. This requires some less-than-ideal manual workarounds: https://github.com/bensheldon/good_job#api-only-rails-applications ...and other problems like: https://github.com/bensheldon/good_job/issues/965 I believe it's possible for...
It would be nice if GoodJob could be configured to disable/ignore priority as a job feature. e.g. `config.good_job.enable_active_job_priority = false`. Why? - For performance reasons: it's not possible to create...
When the Dashboard went through heavy redesign, the jobs table was rewritten to not use `` elements. I've wondered if that was the wrong choice for markup and accessibility reasons....
- https://github.com/bensheldon/good_job/blob/fd2ab71/app/models/good_job/batch.rb#L95-L95 - https://github.com/bensheldon/good_job/blob/fd2ab71/app/models/good_job/batch.rb#L105-L105 - https://github.com/bensheldon/good_job/blob/fd2ab71/app/models/good_job/batch_record.rb#L48-L48
Previously discussed: - https://github.com/bensheldon/good_job/issues/687#issuecomment-1206686169 - https://github.com/bensheldon/good_job/issues/725
## Upgrade blocking application needs - [ ] Application developers need to ensure that all unfinished jobs are "discrete". This means ensuring being up to date on database migrations, and...
``` Failures: 1) ActiveJob::QueueAdapters::GoodJobAdapter#initialize when in development environment runs async Failure/Error: expect(THREAD_ERRORS).to be_empty expected `[["GoodJob::Scheduler(queues=* max_threads=5)-worker-1", #, ["/home/runner/work/good_job/good_job/vendor/bundle/ruby/2.7.0/gems/rack-mini-profiler-3.0.0/lib/patches/db/pg.rb:110:in `exec'", "/home/runner/work/good_job/good_job/vendor/bundle/ruby/2.7.0/gems/rack-mini-profiler-3.0.0/lib/patches/db/pg.rb:110:in `async_exec'", "/home/runner/work/good_job/good_job/vendor/bundle/ruby/2.7.0/gems/activerecord-6.1.7.2/lib/active_record/connection_adapters/postgresql/database_statements.rb:19:in `block (2 levels) in query'", "/home/runner/work/good_job/good_job/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.7.2/lib/active_support/dependencies/interlock.rb:48:in `block in...
Thinking about #912, and looking at the Batch code, I think that it would be possible to defer creating the batch. For example, if no jobs are added to a...
#810 makes me see there's some tech-debt in the `Notifier` because it's more of a reactor now, but still has a lot of the terminology of when it simply did...