good_job icon indicating copy to clipboard operation
good_job copied to clipboard

Job arguments in dashboard?

Open majkelcc opened this issue 2 years ago • 2 comments

Hi,

Migrating from Sidekiq I'm missing jobs arguments in the jobs lists. Would a PR adding them be welcomed?

While talking about jobs arguments, is there a reason to display {"attempt"=>1, "_aj_ruby2_keywords"=>["attempt"]} vs {attempt: 1}?

majkelcc avatar Jun 14 '23 06:06 majkelcc

I'm open if you think you can make it work fitting that info into the table.

For formatting the job arguments, it hasn't been top of my priority list, so if you think you can clean it up, I'd appreciate that. The only thing I'd be worried about is making sure that we're not hiding/masking information that would be useful when debugging, or introducing any performance issues (for example, I want to avoid loading ActiveJob constants).

bensheldon avatar Jun 15 '23 02:06 bensheldon

I'm open if you think you can make it work fitting that info into the table.

This indeed turned out to be a problem very early. I'll see what I can do.

As for the arguments, these _aj_ arguments seem to be internal to ActiveJob and there shouldn't be any harm in removing them from the view (Sidekiq is not displaying them).

(...) or introducing any performance issues (for example, I want to avoid loading ActiveJob constants)

👍

majkelcc avatar Jun 20 '23 06:06 majkelcc