Errors,Patches: Capistrano 2.5.19 and Sprinkle 0.3.1

[Gladcraft]

Hi Ben, thanks very much for this deploy tool! I had to make the following changes to make it run out of the box with the above latest versions of Capistrano and Sprinkle. No doubt there are easier answers, and I'll be glad to know them. Meanwhile, here's what I came up with. See my commits at http://github.com/Gladcraft/passenger-stack.

1. removed the word 'sudo' from statements within packages. It seems capistrano was already applying sudo, and having it again in the statement was crashing the script.
2. removed line continuations ('/') in the nginx init file because they were being translated to '/n' on the server and breaking the functionality.

I also changed the server type to nginx and changed the ree version to 1.8.7-2010.02, but these were preferences, not errors. I thought I was having a problem loading ree 1.8.7-2010.01, but that works fine.

Is this helpful? Was there an easier way?

Thanks, David Kaplan

[Gladcraft]

p.s. I had to remove 'sudo' from has_gem in the ruby initializer script in Sprinkle too. See http://github.com/Gladcraft/sprinkle. I'm going to post a note to Crafterm as well.

[benschwarz]

Hi David,

I had a quick browse over your changes this morning. I think they're great—I'll look to pull them across when I get some spare time (perhaps over the weekend?)

I'd almost be in a mind to upgrade ruby to 1.9.2, but I guess I'll wait until there is a REE 1.9x build.

I'm not using passenger-stack much these days so your updates are great for everyone else. If you can appropriate changes to the readme to reflect your changes, I'd appreciate it...

Big ups. Talk soon.

[Gladcraft]

Awesome! Thanks for the feedback =)

[Gladcraft]

Since all I did was restore previous functionality, the only useful thing I could think of to add to the README were the dependency versions I tested. Committed.

[kbighorse]

Thanks for number 2: here is the error that had resulted:

/Users/kimball/.rvm/gems/ree-1.8.7-2010.02/gems/capistrano-2.5.19/lib/capistrano/command.rb:173:in `process!': failed: "sh -c 'sudo -p '''sudo password: ''' sudo /etc/init.d/nginx start'" on example.com (Capistrano::CommandError)

Much more useful error from trying on the server directly:

$ sudo /etc/init.d/nginx start Starting nginx: invalid option: "n"

[benschwarz]

kbighorse, I don't understand this comment. Is it a new bug?

[Gladcraft]

I think kbighorse is just providing confirmation and additional detail of symptoms of #2 in my message, "removed line continuations ('/') in the nginx init file because they were being translated to '/n' on the server and breaking the functionality."

As for #1, I think it may have been due to a noob move on my part, removing root from the sudoers file, thus when sudo was executed within sudo, it didn't work. Haven't verified, but suspect that's it.

[kbighorse]

yes, I was just providing more detail for issue #2 Gladcraft described above, so maybe someone who searches for this error might come across this helpful thread.