Ben Ridley

Results 27 comments of Ben Ridley

I think it'd also be useful to clarify the overall position of the project when it comes to expanding operations. Is it intended to be a 'batteries included' type project...

Sorry all, have been traveling recently. It looks like this information is read from the registry key `SOFTWARE\Microsoft\Windows NT\CurrentVersion`, which appears to be staying as Windows 10, major version 10,...

So I did some digging, and this appears to be a widely acknowledged issue. Unfortunately, the API calls and registry entries have not been updated to add a way to...

I agree @breed808, IMO it's better to keep the exporter 'pure' and move any handling for identifying Windows 11 up into the business logic of whatever is consuming the metrics....

Thanks @breed808, I've opened #1051 to address this one. Let me know if there's anything else I can do!

It seems I've fixed the tests that were failing, but I'm not sure what's going wrong with the 'mixin' part of the CI pipeline, it looks unrelated to my changes...

Thanks @PhilipGough, I've just rebased so we'll see how it goes.

Sure @beorn7, I think that's a good suggestion and keeps the terminology consistent with Go's stdlib. Happy to add this.

Hey @piotr1212, Yeah it's coming - I was mainly waiting on #2779 because I knew I'd need to rebase and fix this code up once that was merged. I'll probably...

I've just rebased onto main, and also added in the following: - Renamed Timezone/time_zone to Location/location as its a more accurate description and consistent with Go's stdlib (thanks @beorn7) -...