obsidian-gitlab-issues icon indicating copy to clipboard operation
obsidian-gitlab-issues copied to clipboard

GitLab Icon is not visible in some (light) themes

Open mahoromax opened this issue 3 years ago • 2 comments

I was about to leave an issue about the option to show the refresh icon in the left ribbon tab/bar not working, but then I found it:

image

I'm using the default (light) theme. Not sure how hard it is to provide different icons for light/dark mode, or whether it can be recolored accordingly, but it's invisible when not hovered over right now.

mahoromax avatar Oct 31 '22 09:10 mahoromax

I have not forgotten about this issue but I don't know what the correct solution should be. If anybody has any pointers that would be appreciated.

benr77 avatar Nov 17 '22 07:11 benr77

Something is wrong with the svg variable that gets inserted in main.js. The variable definition isn't in the repo, but I changed it in the compiled plugin to

var gitlab_icon_default = '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100"><path fill="currentColor" d="M 98.339844 39.589844 L 98.199219 39.214844 L 84.585938 2.351562 C 84.308594 1.628906 83.820312 1.015625 83.1875 0.597656 C 81.886719 -0.238281 80.226562 -0.144531 79.019531 0.832031 C 78.441406 1.320312 78.019531 1.984375 77.8125 2.734375 L 68.621094 31.914062 L 31.410156 31.914062 L 22.21875 2.734375 C 22.019531 1.980469 21.597656 1.316406 21.011719 0.828125 C 19.804688 -0.148438 18.144531 -0.242188 16.84375 0.59375 C 16.210938 1.011719 15.722656 1.625 15.445312 2.34375 L 1.808594 39.195312 L 1.671875 39.566406 C -2.355469 50.484375 1.066406 62.84375 10.054688 69.882812 L 10.101562 69.921875 L 10.226562 70.015625 L 30.960938 86.128906 L 41.21875 94.1875 L 47.46875 99.082031 C 48.96875 100.265625 51.046875 100.265625 52.546875 99.082031 L 58.796875 94.1875 L 69.054688 86.128906 L 89.914062 69.917969 L 89.964844 69.875 C 98.933594 62.832031 102.347656 50.492188 98.339844 39.589844 Z M 98.339844 39.589844 "/>\n</g>\n';

and now it inherits the colors from the theme.

Tested with minimal

cathelijne avatar Nov 10 '23 13:11 cathelijne