wsl-ssh-pageant icon indicating copy to clipboard operation
wsl-ssh-pageant copied to clipboard

Published 20 hours ago • verified publisher icon benpye

Replaced go-bindata with go1.16's embed feature

Open mixcode opened this issue 3 years ago • 2 comments

Go 1.16 introduced a language built-in file embedding feature, 'go embed'. This patch replaces the use of go-bindata with go-embed regarding the systray icon. By this change, the 'go generate' stage could be removed from the build process; hence the package would be directly installable with 'go install' command.

mixcode avatar May 12 '21 00:05 mixcode

Hi, I am the submitter of this pull request.

I can see the azure-pipeline CI check failures. I presume that azure-pipelines.yml have to be updated to solve the CI check error, but I think that is out of this patch's intended scope, so I decided not to touch the settings.

mixcode avatar May 12 '21 02:05 mixcode

Hey - thanks for the PR!

I'll try and figure out the build failure, the image should have Go 1.16 but it's not the default. Once that's fixed this PR looks good to merge.

benpye avatar May 12 '21 02:05 benpye