benpicco comments

Results 395 comments of


                                            benpicco

gnrc_netif: make use of counting event

#18201 would certainly be the least invasive change. My concern for creating this PR was that I imagined many other places, where event users might be surprised by the singleton...

gnrc_netif: make use of counting event

Now I'm confused. #18204 makes all events counting and thus changes the API which may have undesired consequences. Instead this PR introduces a separate counting event type (and tries to...

gnrc_ipv6_nib: add support for timestamp option in RAs, use for timesync

The idea is to get multiple boards in a sensor network synced up with reasonable accuracy. Adding the timestamp to the RA basically gets me that 'for free' (avoiding round-trips...

gnrc_ipv6_nib: add support for timestamp option in RAs, use for timesync

The idea was to get the time sync 'for free' without any additional network traffic. But I still have to test how well this works in practice.

pkg/lwip: use sys/event for handling ISR and bhp

This needs a rebase.

drivers/{dose, slipdev, sam0_eth}: generate RX event for queued packets

Yes this fixes the issue. (Although for SLIP I would prefer #18066)

drivers/{dose, slipdev, sam0_eth}: generate RX event for queued packets

I can just rebase #18066 if this gets merged

drivers/{dose, slipdev, sam0_eth}: generate RX event for queued packets

Thank you for the review! Glad to have this bug fix.

sys/shell: make cmds submodules and add KConfig modeling

Still WIP?

cpu/esp32: extend GPIO wake-up from deep sleep

That API is rather *bespoke*. On SAM D5x/E5x I had the same problem, only RTC tamper pins can wake the CPU from Deep Sleep. But I just added this to...