benpicco

Results 395 comments of benpicco

Thank you! What's weird is that neither `sensebox_samd21` nor `esp32-wrover-kit` have this.

Since this is a single commit, we can do the squashing in Github directly

> Can we consider the members of some `sock__ep_t` as implementation details not to be touched by application developers? Certainly not, it's not uncommon to statically initialize a e.g. `sock_udp_ep_t`...

> IMO, keeping it that way also keeps it a bit sane. The address types in `sys/net/ipvX/addr.h` are quite complex. That argument is pretty odd, on the one hand we...

> Should we also encode revision data in as well? Maybe a bit off-topic, but we have ```make ifneq (, $(BOARD_VERSION)) BOARD := $(BOARD)-v$(BOARD_VERSION) CFLAGS += -DBOARD_VERSION=$(BOARD_VERSION) endif ``` I...

I can confirm that ACK timeouts still work on `at86rf215` which (ab)uses `NETDEV_MSG_TYPE_EVENT` for [ACK timeouts](https://github.com/RIOT-OS/RIOT/blob/master/drivers/at86rf215/at86rf215_netdev.c#L763). I'm happy to jettison this code when the new sub-Mac is merged :smile:

Well I was hoping to get #14950 merged before any new sub-MACs pop up :wink:

`esp_wifi` and `atwinc15x0` are handled by `gnrc_netif_ethernet.c` I assume? Feel free to squash.