Benoît Grélard

Results 264 comments of Benoît Grélard

Happy for you to kickstart a PR and we can go from there!

Yeah, @jjenzz is correct. I will rename and transfer this issue to the website repo instead for us to follow up on.

@josias-r, This is really clever! I was wondering if we would be able to do it by location rather and that's exactly what you've done here. I think we should...

> Currently, React re-maps oninput events to onChange so our onValueChange events do the same. Would we change our onChange events to behave like native onchange (i.e. publish value onblur)...

Ah that's cool, I didn't even think to check the native one. I didn't really answer your question though. I can't see ourselves having to rename all the onChange handlers...

I meant more with regards to what our `onChange` (`onValueChange` in this case) means/works.

Oh I see, I read back and saw you meant relative to the native `oninput` and `onchange` events. I think my vote would go to add additional `onValueCommit` events in...

Hey @cdeutsch, What do you mean exactly by "the debugger is totally off" and "you can no longer step through the code"? Looking at your screenshot, I'm not sure I...

Thanks, I will try and see if I can replicate your issue.

I think it should be its own API rather than using `DropdownMenu` as some behaviour differs in terms of keyboard and pointer events. It will likely be built from `Menu`...