gunicorn icon indicating copy to clipboard operation
gunicorn copied to clipboard

alias CLD to CHLD in signal handlers

Open jcjones1515 opened this issue 1 year ago • 2 comments

image

some systems have 17 mapped to both CHLD and CLD, this prevents a CHLD signal from being handled in this case

I observed on our systems this issue prevented the arbiter from recognizing a worker getting killed and did not restart it.

This may be addressed by https://github.com/benoitc/gunicorn/pull/3148, although that has quite a few other changes. Happy to close this one if #3148 is preferred.

jcjones1515 avatar Feb 06 '24 05:02 jcjones1515

@jcjones1515 what systems have this ? Can you give an example?

benoitc avatar Apr 16 '24 22:04 benoitc

Most of them, just not macOS. Python has even recently updated their documentation to clarify that SIG* is is just whatever the C library says - hence no such alias on macOS, hence no duplicate key bug in SIG_NAMES there.

Highly prefer a proper cleanup like the two approaches demonstrated in https://github.com/benoitc/gunicorn/pull/3148 over a spot-workaround like this here.

pajod avatar Apr 23 '24 02:04 pajod