gunicorn icon indicating copy to clipboard operation
gunicorn copied to clipboard

Fix signature of the "fall through" InotifyReloader

Open jkugler opened this issue 5 years ago • 1 comments

The signature of __init__ on the "fall through" InotifyReloader was missing the extra_files paramater, so specifying the inotify reload engine on the command line when one did not have inotify installed would, instead of a nice message about needed inotify installed would result in the following traceback:

[2020-10-30 00:55:43 +0000] [7] [ERROR] Exception in worker process
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/gunicorn/arbiter.py", line 583, in spawn_worker
    worker.init_process()
  File "/usr/lib/python3/dist-packages/gunicorn/workers/base.py", line 132, in init_process
    self.reloader = reloader_cls(extra_files=self.cfg.reload_extra_files,
TypeError: __init__() got an unexpected keyword argument 'extra_files'

I didn't see an easy way to writing a test for this, but would be happy to take pointers.

jkugler avatar Oct 30 '20 01:10 jkugler

Is there any reason why this PR is stuck? Any feedback from @benoitc?

frafra avatar May 21 '22 13:05 frafra

Bump?

jkugler avatar Nov 08 '22 23:11 jkugler

thanks for the PR

benoitc avatar May 07 '23 21:05 benoitc