couchbeam icon indicating copy to clipboard operation
couchbeam copied to clipboard

add maps support

Open stofel opened this issue 10 years ago • 6 comments

Hi, i add maps support by add couchbeam:open_doc(Db, DocId, Options), Options = [return_maps] Work, but not heavy tested

stofel avatar Oct 31 '15 13:10 stofel

Add ifdef(MAP_SUPPORT) help to pass the tests? How to be with jsx dependecy which should be updated to version with maps support?

stofel avatar Nov 01 '15 05:11 stofel

Also need add to documentation: For maps support add to rebar.config {erl_opts, [{d, 'MAPS_SUPPORT'}]}.

stofel avatar Nov 01 '15 10:11 stofel

@stofel what do you mean by How to be with jsx dependecy which should be updated to version with maps support? is upgrading the dependency enough?

About tests, they should be upgraded to unit or ct, but waiting that what would be the best way to rerun them <ith maps support? Any idea?

benoitc avatar Nov 04 '15 07:11 benoitc

My mistake, jsx is ok. add {erl_opts, [{d, 'MAPS_SUPPORT'}]} to rebar.config get test passed? but its becouse new code not tested :)

stofel avatar Nov 04 '15 14:11 stofel

@stofel couchbeam 1.2.1 is released. Tests are now using eunit. It should be feasible to test both by looping over them. Hopefully we can have it in another release this week :)

benoitc avatar Nov 04 '15 15:11 benoitc

rebar3 eunit ignore ifdefs. I dont know how to resolve this :(

stofel avatar Nov 05 '15 07:11 stofel