benoit74
benoit74
#191 added `#noqa: A003` in Book class used to represent Book DB table because `id` and `license` are shadowing Python builtin. Those fields should be renamed (at least license, id...
#116 mentioned that Datatables should be removed from repository. Indeed there are many other external dependencies which should be removed from repository: - jquery + jquery UI - fontawesome -...
`# noqa: S113` hint has been added by #191 in `utils.py` This hint detected that we are using `requests` without specifying a timeout. We should add one. To be decided:...
`noqa: PLR2004` magic number hint has been added by #191 in `urls.py` What is this magic number? To be expressed more clearly
Many `# type: ignore` hints have been added in `Global.add_item_for` calls in #190. Those hints are linked to inproper type hints in old zimscraperlib. Those hints have to be removed...
#190 had to set two `# noqa` (B020 and B018) hints in `optimize_epub` in `export.py`. Should we fix something?
Logs are sometimes done with `print` or `pp` which means they escape the logging mechanism allowing to filter messages. For now #191 marks them with `# noqa: T201" and `#...
See https://github.com/openzim/overview/issues/21
I apologize in advance for my limited libzim / libkiwix expertise, you might have to rephrase everything below. In python-scraperlib, when adding items to the ZIM we can mark them...
Currently kiwix-serve is caching ZIMs / open entries and its cache size is only limited by number of ZIMs / open entries (if I understood @mgautierfr well). We could probably...