benoit74

Results 604 issues of benoit74

https://github.com/openzim/mwoffliner/pull/2203 has introduced the ActionParse renderer which seems quite promising. It is supposed to be well working on all Mediawiki instances, so we might wonder if we really want to...

enhancement

vector skin (used only for ActionParse renderer for now) introduced in https://github.com/openzim/mwoffliner/pull/2203 is quite limited in terms of responsiveness. Display on small screens is quite broken. This is not a...

enhancement
question

This is a blocker for release at large of mwoffliner 1.14 See e.g. https://dev.library.kiwix.org/viewer#wikipedia_en_basketball_maxi_2025-02/A/Slovenia_men's_national_under-20_basketball_team ![Image](https://github.com/user-attachments/assets/b4a85627-1bef-4f28-9e43-672e343fefa0) Vs mwoffliner 1.13: https://library.kiwix.org/viewer#wikipedia_en_basketball_maxi_2024-06/A/Slovenia_men's_national_under-20_basketball_team ![Image](https://github.com/user-attachments/assets/cd372022-b6ef-4973-ab92-22d76d9f57ca) This seems to impact all ZIMs, we also have the...

bug

Following https://phabricator.wikimedia.org/T360589 Wikimedia will start to serve images only at fixed width to save storage on their cache. For instance, if the Wikitext requests the image thumbnail at 900px, in...

enhancement

Before upgrade to ESLint 9 in https://github.com/openzim/mwoffliner/pull/2217, we had multiple plugins configured. These plugins have been removed due to issues configuring them with ESLint 9. We should add them back...

enhancement

For now only ActionParse rendered introduced in https://github.com/openzim/mwoffliner/pull/2203 is using a skin system. At some point, we might want to retrofit other renderers to also use this skin system.

enhancement
question

While https://github.com/openzim/mwoffliner/pull/2196 ensured that we are at least aligned with ZIM naming convention, computing the ZIM filename from the articleList seems to not be that a great idea according to...

enhancement
question
good first issue

The `getJSON` and `getJSONcb` are "abused" to get any kind of data, typically when fetching HTML of an article in the RESTApi renderer (e.g. https://cyclowiki.org/w/rest.php/v1/page/%D0%97%D0%B0%D0%B3%D0%BB%D0%B0%D0%B2%D0%BD%D0%B0%D1%8F_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D0%B0/html which does not return JSON...

bug

Command used to repro: ``` mwoffliner --webp --mwUrl="https://www.appropedia.org" --format="novid" --verbose="log" --publisher="openZIM" --adminEmail="[email protected]" --customZimTitle="Test" --customZimLanguage="eng" --customZimDescription="Test" ``` Version: 1.14.1-dev0 After few articles, the scraper gets rate-limited (note that it is using...

bug

mwoffliner version : 1.14.0 Task: https://farm.openzim.org/pipeline/1e755f21-4805-4cf8-8fa1-63fd5a5dc9d5/debug Recipe: https://farm.openzim.org/recipes/cyclowiki.org_rus_all Request: https://github.com/openzim/zim-requests/issues/9 Log: ``` [error] [2025-01-13T13:46:08.126Z] Failed to run mwoffliner after [1s]: { "stack": "Error: mwUrl [https://cyclowiki.org] is not valid.\n at file:///tmp/mwoffliner/lib/sanitize-argument.js:134:15\n...

bug
question