Benoit Pierre
Benoit Pierre
I know you don't manage the pc files yourselves, but you do provide an image with a number of homebrew packages pre-installed. So are you going to update the image...
OK, thanks.
I don't understand why a Circle CI build is not triggered… ¯\\_(ツ)_/¯
I think the CircleCI checks are not run because I've enabled my fork on CircleCI. Another casualty of the fact that CircleCI run the checks directly on the PR branch...
Here's the [run](https://app.circleci.com/pipelines/github/benoit-pierre/koreader-base/70/workflows/fcda6b4d-4e9d-4075-9edc-f54719545aa2).
This can be closed, as #1750 includes giflib 5.2.2.
Is this still relevant with #1750?
I can compile #1750 fine in docker (image: [opensuse/leap](https://hub.docker.com/layers/opensuse/leap/latest/images/sha256-57958e44b5aa446b1466e06f6c74150e54ec5e44347a1242ef40d054b2ef8ebc?context=explore)).
Is this still relevant?
This might be more useful: https://github.com/cmake-lint/cmake-lint.