nx-electron icon indicating copy to clipboard operation
nx-electron copied to clipboard

Update to Support Nx 19

Open cliftonlabrum opened this issue 1 year ago • 2 comments

When I run:

npm install -D nx-electron

...in my Nx 19.2.2 project, I get a dependency conflict:

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: @myproject/[email protected]
npm error Found: @nx/[email protected]
npm error node_modules/@nx/workspace
npm error   dev @nx/workspace@"19.2.2" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @nx/workspace@"^18" from [email protected]
npm error node_modules/nx-electron
npm error   dev nx-electron@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

Any chance you can update this package to support the latest version of Nx? Or is there a workaround I'm not familiar with? I'm new to Nx. 😊

cliftonlabrum avatar Jun 07 '24 23:06 cliftonlabrum

While waiting for the update, it seems like you can temporarily overload the dependency in your package.json:

"overrides": {
    "nx-electron": {
      "@nx/workspace": "19.2.2" // Or whatever version you are using.
    }
  },

I managed to generate a working app this way 😄.

@bennymeg I am not very familiar with NX schematics system and thus don't know if the update is just above bumping dependencies. Feel free to let me know if you feel like it's easy enough and want me to submit a PR.

fhemery avatar Jun 10 '24 12:06 fhemery

@fhemery Tnx, I'm, working on it on a separate branch. I wanted to try and add vite support for this version, but I see I won't have a chance. Will release it soon.

bennymeg avatar Jun 16 '24 18:06 bennymeg

When do you plan working on this issue, or this repo in general? I'd just like to know what to expect.

ferenc-a avatar Aug 09 '24 10:08 ferenc-a

@bennymeg can you please release the v19 version?

brnbs avatar Sep 13 '24 06:09 brnbs

I did not get the check to properly test it. I can release an alpha.

bennymeg avatar Sep 19 '24 12:09 bennymeg

published

bennymeg avatar Sep 24 '24 08:09 bennymeg