fairybread

fairybread copied to clipboard

Closes #85

repne

System.MissingMethodException on HC 13.0.0

6

``` System.MissingMethodException: Method not found: 'HotChocolate.NameString HotChocolate.Types.Descriptors.Definitions.DefinitionBase.get_Name()'. at void FairyBread.ValidationMiddlewareInjector.OnBeforeCompleteType(ITypeCompletionContext completionContext, DefinitionBase definition, IDictionary contextData) at void HotChocolate.Configuration.AggregateTypeInterceptor.OnBeforeCompleteType(ITypeCompletionContext completionContext, DefinitionBase definition, IDictionary contextData) at void HotChocolate.Types.TypeSystemObjectBase.OnBeforeCompleteType(ITypeCompletionContext context, DefinitionBase definition, IDictionary...

repne

Added support for MutationConventions

6

Added support for MutationConventions. Must use "[Error(typeof(ValidationException))]" on mutations with enabled conventions. At the current time it is necessary to overwrite the DefaultValidationErrorsHandler to support errors apart from the "ValidationException"...

FleloShe

Support for payload errors (MutationConventions, 6a)

12

Currently there seems to be no support for the [Mutation Conventions](https://github.com/ChilliCream/hotchocolate/tree/main/src/HotChocolate/Core/src/Types.Mutations) as described [here](https://chillicream.com/docs/hotchocolate/defining-a-schema/mutations) in 9.0.0-rc.1. I think I identified the following issues: - Validators are not applied to parameters...

FleloShe

Rename Dont* types

1

I'm not sure if the method of renaming/obsoleting is correct. Please let me know. Closes #82.

glen-84

Consider renaming Dont* types

3

I _don't_ (😉) love the use of contractions in type/variable names. What do you think about alternatives like: `DontValidateAttribute` -> `DisableValidationAttribute` -> f.e. `[DisableValidation]` `DontValidateImplicitlyAttribute` -> `DisableImplicitValidationAttribute` -> f.e. `[DisableImplicitValidation]`...

glen-84

Consider allowing passthrough execution to resolver/mutation even if validator fails

4

Use case: Sometimes you may want to treat the validation as a _partial_ failure, and allow the mutation/resolver to execute anyway, so a payload can be returned. Might I suggest...

oising

Implicit Validation of Collection-Type Models

1

Got a report from Oisín Grehan and Nacer Dergal in Slack of a scenario where they weren't seeing the validator run. Turns out they had an array arg where the...

benmccallum

benmccallum

Expose validation rules via schema / field

1

Goals: 1. Expose FluentValidation rules via schema 2. Accessibility - support pulling validation copy from resource files globalization (i18n) Stretch goals: 1. Support/execute + expose DataAnnotation attributes

benmccallum