angular-ui-tour icon indicating copy to clipboard operation
angular-ui-tour copied to clipboard

Published 20 hours ago • verified publisher icon benmarch

Step destroy

Open balazsnemeth opened this issue 8 years ago • 1 comments

When i created a step using createStep, it's going to automatically create the popup as well and insert it to the DOM. However I had no service to properly destroy/remove this step (returned by createStep), so I created a service.

@benmarch Let me know your thoughts if I need to structure my code on a different way or if something is missing. Thanks, and thanks for this library!

balazsnemeth avatar Sep 28 '17 01:09 balazsnemeth

Hey @balazsnemeth, this looks good to me, sorry I introduced the conflict. Can you add some test cases for these changes?

What do you think about making destroy() a method on the step itself instead of on the tour?

I think it would be good to call destroyStep() in the tourStepDirective when the scope is destroyed. What do you think?

Can you also revert the changes to the distribution file? I will generate that when I do the release.

benmarch avatar Sep 29 '17 04:09 benmarch