Veniamin Malefioudakis
Veniamin Malefioudakis
@sarthakpati yes of course..!!
Hi guys @VukW, @sarthakpati, Thanks for the detailed review. I agree with it. I will do it.
@sarthakpati @VukW I added a [Logging section](https://github.com/benmalef/GaNDLF/blob/add_logging_final_version/docs/extending.md#logging) in the documentation for extending GaNDLF
@VukW @sarthakpati I have tried to implement [this](https://github.com/mlcommons/GaNDLF/pull/893#discussion_r1674165923). - Updated the `ganldlf_logger`. - I added the [`colorlog`](https://pypi.org/project/colorlog/), to beautify the logs in the console. As mentioned, a new separated PR...
@sarthakpati I made the proposed changes...!! Thanks a lot for the suggestions.!!
> Looks good, but should we not be using this for all Docker builds? It's the same with [this](https://docs.mlcommons.org/GaNDLF/usage/#running-with-docker), IMO but in an easier way. You can modify the compose.yaml....
I have created an example to demonstrate how to use it, but I have noticed that extra effort is required from the user to modify the compose.yaml file. Using the...
Hi @VukW, First of all, thanks for your review and your comments. They are very meaningful. I will try to address them as soon as possible. > Concerning tqdm, your...
> concerning tqdm: we can use the following wrapper to handle the redirect context automatically: > > ```python > def custom_tqdm(it: Iterable, *args, **kwargs): > with logging_redirect_tqdm(): > for x...
Hi @VukW, @sarthakpati I am trying to solve this error in Openfl-test. It can not find the logging_config.yaml file. Locally, it is running fine without any errors. Any thoughts ???...