visual-regexp.el icon indicating copy to clipboard operation
visual-regexp.el copied to clipboard

Support all query-replace-regexp interactions

Open PhilHudson opened this issue 2 years ago • 2 comments

Surprised to find that C-w did not do what it does in query-replace-regexp (delete the current match and enter recursive edit). Instead it aborts the search and does what C-w normally does at the top level.

Looking at the code, I see that vr--perform-query-replace notes that it is an ad-hoc replacement for the original perform-replace. I imagine it has got out of sync with the original over time.

PhilHudson avatar Dec 04 '23 13:12 PhilHudson

Hi

I just tried it on Emacs 28 and C-w simply killed the match and stops the query-replace-regexp command. Did you mean C-r? I see that C-r works for query-replace-regexp but not for visual-regexp.

Unfortunately I don't have the time to work on this package. Pull requests are welcome though.

benma avatar Dec 09 '23 05:12 benma

Your observed behavior is confirmation of the bug I'm reporting (failure to enter recursive edit). See (info "(emacs) Query Replace") for the expected behaviors.

PhilHudson avatar Dec 09 '23 10:12 PhilHudson