benma

Results 434 comments of benma

> Usually you don't need to call Check from your business-logic application I am currently dealing with a corrupt database file in production, where iterating the keys in one bucket...

> @benma Is it possible for you to share the corrupt database? I found two databases from around that time, but I don't know anymore if these are the ones...

I am also running into the issue that `Check()` on a corrupt DB crashes. `Check()` should definitely return an error instead of panicking. [panics-on-check.db.zip](https://github.com/etcd-io/bbolt/files/9969670/panics-on-check.db.zip) cc @serathius - I saw you...

> Would be nice to have that `openFile func(string, int, os.FileMode) (*os.File, error)` function return something like `io.ReaderWriterSeeker` instead of `*os.File` which is a pointer to a struct. That way...

https://github.com/ElementsProject/secp256k1-zkp/issues/154 is a prerequisite for antiklepto - I will work on it.

I opened a draft implementation here: https://github.com/bitcoin-core/secp256k1/pull/1140

@dr-orlovsky what is the status of your work? Do you plan on continuing it? I'd be very interested in using this to implement the antiklepto/anti-exfil protocol in the BitBox02 for...

@dr-orlovsky thanks, I'll take this task then

I opened a draft implementation here: https://github.com/bitcoin-core/secp256k1/pull/1140

Thanks for the report. @Tomasvrba @shonsirsha grepping `split` in WC-related files, maybe the issue is here? https://github.com/digitalbitbox/bitbox-wallet-app/blob/7f336345f03734d3e2e8081bc57a216a81e3ec7d/frontends/web/src/components/wallet-connect/incoming-signing-request-dialog.tsx#L76 Can `signingData` be undefined? It seems it can at least be empty: https://github.com/digitalbitbox/bitbox-wallet-app/blob/7f336345f03734d3e2e8081bc57a216a81e3ec7d/frontends/web/src/components/wallet-connect/incoming-signing-request-dialog.tsx#L116...