grails-cookie-session icon indicating copy to clipboard operation
grails-cookie-session copied to clipboard

support for withForm

Open benlucchesi opened this issue 10 years ago • 5 comments

It looks like the object used to hold keys used by the withForm method isn't serializable and is getting dropped from the session object. either that or the object isn't getting written to/read from the session before or after the cookie session is loaded. need to investigate.

benlucchesi avatar Dec 02 '14 07:12 benlucchesi

We were testing out this plugin as a replacement for container based sessions, but ran into the same withForm issue. The form token appears to be added to the session after render is called as it's generated in the gsp. Because the gsp is rendered after grails has set the status on the request, there is no chance to capture further changes to the session, and write out the new cookies. I have a fix for this that I'll do a pull request for shortly.

exell-christopher avatar Apr 04 '15 02:04 exell-christopher

great. that will be much appreciated. looking forward to it.

benlucchesi avatar Apr 04 '15 04:04 benlucchesi

hey exell-christopher,

were you able to test your changes with the test-suite as described in the response to your pull request?

-ben

benlucchesi avatar Apr 13 '15 17:04 benlucchesi

I haven't had a chance to get back to this yet. Hoping to sometime this week.

On Mon, Apr 13, 2015 at 10:32 AM, Ben Lucchesi [email protected] wrote:

hey exell-christopher,

were you able to test your changes with the test-suite as described in the response to your pull request?

-ben

— Reply to this email directly or view it on GitHub https://github.com/benlucchesi/grails-cookie-session-v2/issues/48#issuecomment-92440564 .

exell-christopher avatar Apr 13 '15 18:04 exell-christopher

Fixed in https://github.com/double16/grails-cookie-session/tree/release/4.0.0

dependencies { compile 'org.grails.plugins:cookie-session:4.0.0.RC1' }

double16 avatar Oct 19 '17 16:10 double16