Ben Keith

If a user enters a Google Docs spreadsheet that has not been "published" with the "File > Publish to the web...." tool in Google Docs, then the request for the...

Programmatic insertion of SCAMP blocks

1

Continuing from #70, which introduced the blocks, let's talk about programmatic insertion of those blocks into stories. - [ ] is this something that we need to do? - [...

General note: https://privacy.google.com/businesses/rdp/ Specific implementation details: https://support.google.com/admanager/answer/9598414 This passes a configuration item to the GPT tag, which is mostly created and handled by jquery.dfp.js, which is drawn from the dfoPoptions...

It shouldn't be output on admin pages.

Fix for non-lazy-load ads not displaying correctly

2

## Changes - Adds the indexes `sizeMapping` and `setTargeting` on the global `window.dfw` to match the parameters required by https://github.com/coop182/jquery.dfp.js#available-options - Moves the initialization of non-lazy-load ads into `jquery.dfw.js`, so...

random log dump; needs triage

1

2018/12/07 14:44:11 [error] 50590#0: *2454 FastCGI sent in stderr: "PHP message: PHP Notice: Undefined index: one in /Users/blk/sites/largo/wp-content/plugins/doubleclick-for-wp/inc/class-doubleclickadslot.php on line 77 PHP message: PHP Notice: Trying to get property 'min_width'...

In the sizeMapping array in `window.dfw`, each individual mapping takes the form of an object/associative array with the keys `browser` and `ad_sizes`. Here's what jquery.dfp.js' docs say the plugin expects:...

## Problem This line of code: https://github.com/INN/doubleclick-for-wp/blob/bf4fcb5423ff359af955948ba253a8e2211185a3/inc/class-doubleclick.php#L210-L212 Can potentially be output upon the page before the script enqueues that load the js: https://github.com/INN/doubleclick-for-wp/blob/bf4fcb5423ff359af955948ba253a8e2211185a3/inc/class-doubleclick.php#L180-L181 On one site in recent memory, the...