scala-guice icon indicating copy to clipboard operation
scala-guice copied to clipboard

Upgrade to Guice 3.0

Open qeishay opened this issue 13 years ago • 6 comments

Any plans to upgrade to Guice 3.0?

qeishay avatar Mar 19 '12 06:03 qeishay

I am working on this now on my fork, hope to have it working later today or tomorrow. End of next week at the latest.

tsuckow avatar Mar 19 '12 12:03 tsuckow

Thanks!

qeishay avatar Mar 19 '12 16:03 qeishay

Ok, I think it works. Let me know if there is anything you think should be changed/added. Note: This is bleeding edge, I just completed it & there is bound to be bugs.

You can use this job as a maven repo: Repository "uk.me.lings" % "scala-guice_2.9.1" % "3.0.1-SNAPSHOT"

Repo: https://github.com/Deathbobomega/scala-guice/tree/guice3-port

Build Server: http://ci.codingwell.net/job/Scala-Guice3/

tsuckow avatar Mar 20 '12 23:03 tsuckow

Ben, I am going through and looking over everything. It seems like the "ScalaModule" and "BindingsExtensions" share a lot in common but expose a different API. Is there a reason for this or would it be better for me to unify them?

tsuckow avatar Mar 22 '12 03:03 tsuckow

Are there plans to integrate these changes?

ijuma avatar May 10 '12 08:05 ijuma

You can ignore that referenced issue; github did the wrong thing for me.

nbauernfeind avatar Dec 15 '12 00:12 nbauernfeind