Ben Langfeld

Results 311 comments of Ben Langfeld

I agree that this doesn't appear to be possible and would require a modification to rpush to allow it.

@J-Swift Would you mind proposing edits to the changelog about this?

I mean would you mind opening a PR to put these notes in the changelog?

Please go ahead and open a PR and we can discuss there.

Could you please add a changelog entry and preferably a test for this?

Superseded by https://github.com/rpush/rpush/pull/673. Thanks!

@guruslan Thanks. This would need tests, docs and a changelog entry to be merged.

Could you provide a reference? What does the Puma project recommend as a replacement?

According to https://github.com/puma/puma/commit/4b9891f0c10fa4f2105b897ff05c20490ee49f7c this is a rename to `before_worker_boot`. Maybe you could submit a PR to correct the docs here?