Ben Kehoe

Results 243 comments of Ben Kehoe

The idea was that the second parameter to `Fn::Map` is a mapping from key to list value, and there could be multiple keys, and then it would match the values...

Hm, maybe? Maybe it could be part of the SAM macro... paging @jlhood

I don't think providing client-side tooling is a good answer, because processes that suffice inside Amazon are not sufficient for many customers. One of the primary advantages of CloudFormation is...

I have a number of different pieces of feedback. ## Naming In the issue I originally opened (#41), I proposed `Fn::Map`; I believe it's important for users to understand this...

re-posting this as a general comment so it doesn't get lost on an old revision: from @benbridts > Things I'm wondering: > > * Would it be clearer to use...

Re-posting this as a general comment so it doesn't get lost on an old revision: Both @benbridts and I commented that we think the parameters should be CamelCase to be...

@MalikAtalla-AWS FYI amending the commit and pushing means comments on previous commits are no longer visible in the diff, I'd recommend creating new commits and only squashing when it's ready...

I'm not sure if YAML supports tags on keys, which would prevent this syntax. I believe the way YAML works, the entire value after the tag is passed to it....

`!Sub` is a [YAML tag](https://yaml.org/spec/1.2.2/#682-tag-directives). It is a marker that the YAML parser uses to interpret the YAML data that follows the tag. So `!SomeTag foo` is a YAML snippet...

While `primaryIdentifier` can be an array (of pointers), a pointer within that array should not point to an array (at least, that's not currently supported). This is not checked during...