aws-sso-util icon indicating copy to clipboard operation
aws-sso-util copied to clipboard

build project from source

Open jftuga opened this issue 3 years ago • 1 comments
trafficstars

Based on our discussion yesterday: Issue: https://github.com/benkehoe/aws-sso-util/issues/58

I have created a bash script that will run these commands to build the project from source. If accepted, I would then like to also submit another PR that will use this script as part of a Github Action that will automatically build and publish a release when you tag a new version. If you have a script that you use to tar and create releases that would be helpful to see so that I could incorporate it.

jftuga avatar Apr 08 '22 09:04 jftuga

I'd rather have this as documentation (e.g., in something like docs/development.md). A lot of the script feels brittle, and in general I think it's unnecessary? For development, instead of building wheels, using the virtualenv managed by poetry (in which poetry installs the project) is preferable. What I'd like is a way to make it easy to change the CLI dependency to be the lib project on disk for development rather than the PyPI version. I have that dependency commented out in pyproject.toml here. As I think about it, I'm not sure what happens if I put that as dev dependency, does it override the normal dependency?

And then for a GitHub Action, there needs to be separate actions. Both the library and CLI get updated independently—the library gets library feature updates that the CLI doesn't use, meaning the CLI doesn't get a new version, and the CLI gets feature updates that don't require changes in the library.

And the action doesn't need a build script; you can again use poetry to handle everything. See this example in aws-error-utils

benkehoe avatar Apr 30 '22 17:04 benkehoe