hlsclt
hlsclt copied to clipboard
windows 10 compatibility
Some minor modifications to make it compatible to windows 10
Eli
Hi Eli,
The latest updates here look good. I have pulled the latest revision and tested on my linux box to make sure there are no breaking changes, looks all good.
Do you think there is much more to do to close out the functionality you wanted to add?
One request i do have - in your latest commit - 8a5b9ab944d7a0f455d6360b83d6e4953cb08930 - you included the generated files for one of the examples. Could you roll this commit back to clean up these files?
I also think it would be good to have an example project with the new cflags options, have you got something simple you are using for testing which could be added?
Cheers, Ben
I want to but I don't know how to roll this commit back. Sorry09.04.2019, 23:30, "Ben Marshall" [email protected]:Hi Eli, The latest updates here look good. I have pulled the latest revision and tested on my linux box to make sure there are no breaking changes, looks all good. Do you think there is much more to do to close out the functionality you wanted to add? One request i do have - in your latest commit - 8a5b9ab - you included the generated files for one of the examples. Could you roll this commit back to clean up these files? I also think it would be good to have an example project with the new cflags options, have you got something simple you are using for testing which could be added? Cheers, Ben
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
instead, I have done some minor cleanup. 17.04.2019, 22:51, "Joe Chan" [email protected]:I want to but I don't know how to roll this commit back. Sorry09.04.2019, 23:30, "Ben Marshall" [email protected]:Hi Eli, The latest updates here look good. I have pulled the latest revision and tested on my linux box to make sure there are no breaking changes, looks all good. Do you think there is much more to do to close out the functionality you wanted to add? One request i do have - in your latest commit - 8a5b9ab - you included the generated files for one of the examples. Could you roll this commit back to clean up these files? I also think it would be good to have an example project with the new cflags options, have you got something simple you are using for testing which could be added? Cheers, Ben
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.