branch-protection-bot icon indicating copy to clipboard operation
branch-protection-bot copied to clipboard

Feature request: disable more settings

Open JoshuaKGoldberg opened this issue 1 year ago • 4 comments

This bot works great for just the "include administrators" part of branch protections (thanks!). But there are other branch protection settings that can be useful to remove from the default branch so that bots can push to it:

  • Requiring an approving review
  • Required status checks

Example build:

ERROR remote: error: GH006: Protected branch update failed for refs/heads/main.        
remote: error: At least 1 approving review is required by reviewers with write access. 10 of 10 required status checks are expected.        
To https://github.com/JoshuaKGoldberg/template-typescript-node-package
 * [new tag]         v1.24.0 -> v1.24.0
 ! [remote rejected] main -> main (protected branch hook declined)

Would you be open to expanding scope of this bot to also disable & enable those?

JoshuaKGoldberg avatar Dec 23 '22 19:12 JoshuaKGoldberg