Benjamin W. Smith
Benjamin W. Smith
Actually, @dkhunt27 has some pretty hefty refactoring going on in #28 and #31 I'm going to give them the commit bit. If you'd like to hit me up on irc...
I've added @victor73 and @dkhunt27 as collaborators. If you'd like to chat about the bad decisions I made in this code, /msg me on irc.
I'll take a look at this. You're right though, if it's a bytes message, it should use buffers instead of strings.
Can you please try out branch issue-15 (https://github.com/benjaminws/stomp-js/tree/issue-15). All it does is convert the body of the message back to a buffer if it's detected that the message is a...
Doh, you're right. I'll try another approach. This whole codebase needs a major refactoring :(
New approach will leave the buffer intact, only slicing out the command/header bits as needed. Can you pull it down and test it for yourself?
Looked at this again. Problem is more annoying that I initially thought. Working on a fix, though. Should have something cooked up tomorrow.
Right. Hence the last note. Will hopefully have a fix today. The problem is the way I'm handling the incoming buffer, trying to treat it as a string initially instead...
It's still alive in bug-fix mode. I haven't had the time to work on the replacement for this, and I'm always looking for contributors :) https://github.com/benjaminws/stomp-js-new
This code is bad, and I feel bad :( I've been on vacation, but I'm starting to get back into the swing of things. I'll look into refactoring this code,...