elixir-sips-downloader icon indicating copy to clipboard operation
elixir-sips-downloader copied to clipboard

[BUGFIX] - xml parse fix, replaced rexml with nokogiri

Open mtunjic opened this issue 9 years ago • 9 comments

broken when tags are not closed

mtunjic avatar Apr 02 '15 20:04 mtunjic

:+1:

benichu avatar May 14 '15 11:05 benichu

Current master doesn't work - this PR fixes that :+1:

dgmcguire avatar Jun 09 '15 13:06 dgmcguire

:+1: Should be merged

hodak avatar Jun 15 '15 17:06 hodak

:+1:

clementdemily avatar Jun 26 '15 11:06 clementdemily

:+1: this fixes master

veverkap avatar Sep 19 '15 17:09 veverkap

lol, I should look in the PR section before debug session. The difference in code is exactly one line!

lessless avatar Sep 26 '15 17:09 lessless

:+1: +1 this fix the issue of:

# ....
I, [2015-10-29T22:59:40.312560 #11143]  INFO -- : Logging in...
I, [2015-10-29T22:59:42.633686 #11143]  INFO -- : Fetching episodes feed...
/home/tomi/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/parsers/baseparser.rb:340:in `pull_event': Missing end tag for 'div' (got "ul") (REXML::ParseException)
Line: 396
Position: 65923
Last 80 unconsumed characters:
    from /home/tomi/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/parsers/baseparser.rb:184:in `pull'
    from /home/tomi/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/parsers/treeparser.rb:22:in `parse'
        #....

till it's merged, anyone having this problem, clone https://github.com/mtunjic/elixir-sips-downloader and it should work

equivalent avatar Oct 29 '15 23:10 equivalent

still errors with this fork for me.

/Users/tejas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/parsers/baseparser.rb:340:in `pull_event': Missing end tag for 'p' (got "div") (REXML::ParseException)
Line: 336
Position: 65614
Last 80 unconsumed characters:
    from /Users/tejas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/parsers/baseparser.rb:184:in `pull'
    from /Users/tejas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/parsers/treeparser.rb:22:in `parse'
    from /Users/tejas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/document.rb:287:in `build'
    from /Users/tejas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rexml/document.rb:44:in `initialize'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/extractors/files.rb:9:in `new'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/extractors/files.rb:9:in `extract'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/extractors/episode.rb:16:in `extract'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/extractors/catalog.rb:17:in `block in extract'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/extractors/catalog.rb:16:in `each'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/extractors/catalog.rb:16:in `extract'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/cli.rb:39:in `create_catalog'
    from /Users/tejas/Repos/tejasmanohar/elixir-sips-downloader/lib/elixir_sips_downloader/cli.rb:19:in `download'
    from bin/elixir-sips-downloader:12:in `<main>'

tejasmanohar avatar Nov 22 '15 04:11 tejasmanohar

:+1: for https://github.com/mtunjic/elixir-sips-downloader fork

rianrainey avatar Jan 27 '16 02:01 rianrainey