Benjamin Petit

Results 80 comments of Benjamin Petit

So the "Block is full" exception could be caused by this `OutOfMemoryException`. Did you find an occurrence where you have this "Block is full" but no `OutOfMemoryException`?

I think it's because we don't check if the block is full _before_ adding an element to it, but rather check after the add occured. Only then we try to...

What would be the use case for a persistence layer in this case? "Subscribers" cannot go back in time in case of `BroadcastChannels`.

Just for logging/audit purpose?

If you are using external clients, subscriptions can be "dropped" if the client cannot be reached by the pulling agent when an event is supposed to be sent. This should...

Hi @buzzers , It seems that your implementation doesn't guarantee stream event order. While it is true that some providers don't guarantee it (like `AzureQueue`), it should be the exception...

For `EventHub` it is not needed since messages are purged after `n` days. But message deletion, if needed, should be done in `IQueueAdapterReceiver.MessagesDeliveredAsync()` (it seems that's what you did in...

We have the same issue with #8931 (I think). I think it would be safer for now to revert to 8.0.33 for the time being. Thought @ReubenBond ?

Well... that's embarrassing. I merged the wrong PR 😓 But I started to review it few days ago. I still think it's a worthy addition for a preview, so let's...