Benjamin Peterson

format Bazel files

1

This prevents automated transformations of BUILD files from making extraneous diff noise.

stub: ensure BlockingClientCall tasks run after cancellation

3

After canceling a `BlockingClientCall`, the caller may not interact with it further. That means the call executor, a `ThreadSafeThreadlessExecutor`, will not execute any more tasks. There may still be tasks...

BlockingClientCall.cancel may orphan and leak pending reads

1

I made a new client for the [`ManualFlowControlServer` example](https://github.com/grpc/grpc-java/blob/7d6ea288a2286af8cac7617810e758c3c9c03f5a/examples/src/main/java/io/grpc/examples/manualflowcontrol/ManualFlowControlServer.java): ```java import io.grpc.Grpc; import io.grpc.InsecureChannelCredentials; import io.grpc.ManagedChannel; import io.grpc.StatusException; import java.time.Duration; public class BidiBlockingClient { public static void main(String[] args) throws...

BlockingClientCall should be AutoCloseable

3

Using the blocking v2 stubs, I've often found myself using a `try`-`finally` pattern like this: ```java var call = SomeGrpc.newBlockingV2Stub(channel).bidiRpc(); try { while (true) { var serverMessage = call.read(); if...

`google.golang.org/genproto/googleapis/longrunning` is just an alias for `cloud.google.com/go/longrunning/autogen/longrunningpb`, so ideally remote-apis-sdks would import the latter not the former. I hope this is something that can be simply tweaked in your export...