Benjamin Peterson
Benjamin Peterson
The lack of calls to `request_capacity()` calls in this testcase means it completely relies on the streaming-dropping auto-release to keep the connection window open. From the client's perspective, when the...
I was wondering if https://github.com/hyperium/h2/pull/860 had an effect on your production version of this issue.
An update to #860 now fixes another case where connection windows could be starved.
Likely most will see this issue vanish as 489d08bf472 propagates.
> One problem with Closeable is linters. There are linters that track Closeables and if you _don't_ call close() then they complain. There will be no way for the linter...
How bad would it be to implement `TransitiveConfiguredTargetValue` by fetching the direct `ConfiguredTarget` deps via skyframe (i.e.., `graph.getDirectDeps()`)?
Sure, but I was thinking the advantage of `TransitiveConfiguredTargetValue` would be that you could have a tree of them, so that every `gencquery` wouldn't have to take direct skyframe dependencies...
Did anyone say there were errors? I thought OP just never wants `@local_jdk` to appear in a query result. :) It's true this issue did sort of morph into us...
The trouble is I don't think `.cancel` should be blocking.
Another option might be to dump post-cancellation tasks on whatever executor would have been used for the call if we didn't force `ThreadsafeThreadlessExecutor` in.