bootstrap_package
bootstrap_package copied to clipboard
benjaminkott
Change JS for bootstrap 5 to vanilla JS
Pull Request
Related Issues
- Resolves #1163
Prerequisites
Rebuild JS by running npm run js inside Build folder.
Description
- Change JS for bootstrap 5 to vanilla JS
- Remove jquery include from typoscript
- Rebuild js which updates modernizer.min.js as well
@mediaessenz not sure why you overwrite my fix again, now test is back to red... So please revert your last commit and push it again.
@mediaessenz not sure why you overwrite my fix again, now test is back to red... So please revert your last commit and push it again.
I do not understand the problem, because I take your file, override my lokal (wrong) one and commit/pushed it again. I did this, because I would like to have the same state in my lokal system than the one in the forked version from where I made the pull request.
@mediaessenz not sure why you overwrite my fix again, now test is back to red... So please revert your last commit and push it again.
I do not understand the problem, because I take your file, override my lokal (wrong) one and commit/pushed it again. I did this, because I would like to have the same state in my lokal system than the one in the forked version from where I made the pull request.
You just had to pull after my push, that's all to have the same state...
i made a huge mess trying to rebase the branch... so i cherry-picked the changes we need and made a new pull request. https://github.com/benjaminkott/bootstrap_package/pull/1212
closing this one - sorry!