looty icon indicating copy to clipboard operation
looty copied to clipboard

Respect Rate Limit Headers

Open johnkernke opened this issue 7 years ago • 1 comments

There are a few headers that get returned to help ease load on the API server. I noticed there was "probably throttling" when getting tabs, and looked through the requests and noticed the following headers are sent back after each request:

X-Rate-Limit-Account
X-Rate-Limit-Account-State
X-Rate-Limit-Policy
X-Rate-Limit-Rules

It would pay to look into these more and make the app not request more than is allowed.

johnkernke avatar Dec 04 '17 09:12 johnkernke

Thanks for pointing that out! I didn't notice (or those didn't exist) when I wrote request layer a few years ago. If I go in there again I'll definitely look into using them. If you want to submit a patch that did I would be happy to accept it.

benjaminjackman avatar Dec 08 '17 04:12 benjaminjackman