Minor fixes

[halkeye]

• Update gitignore with stuff from gitignore.io
• Update gitignore with compiled code
• Add specific list of included files for npm (test with npx pkgfiles)

pkgfiles output:

PATH           SIZE     %   
gatsby-ssr.js  538 B    1%  
package.json   1.09 kB  2%  
index.js       2.57 kB  4%  
README.md      7.29 kB  10% 
yarn.lock      59.1 kB  84% 
                            
DIR            SIZE     %   
.              70.6 kB  100%

PKGFILES SUMMARY
Size on Disk with Dependencies  ~25.4 MB
Size with Dependencies          ~10.5 MB
Publishable Size                ~70.6 kB
Number of Directories           1       
Number of Files                 5       

[benjaminhoffman]

open to the changes on package.json and .gitignore. thank you!

but shouldn't the change to index.js be included in https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/pull/10 instead?

[halkeye]

It was probably added by mistake.

but on that note I don't think index.js should be in git, only src/index.js

To me the compiled code is too easy to forget (like i did) or have merge conflicts because its generated code.

I think you should have npm run build for your pre-publish - https://docs.npmjs.com/misc/scripts

On Sat, Jun 9, 2018 at 9:50 PM Benjamin Hoffman [email protected] wrote:

open to the changes on package.json and .gitignore. thank you!

but shouldn't the change to index.js be included in #10 https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/pull/10 instead?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/pull/11#issuecomment-396020334, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGuBxTY9bmroZRYzl9uVvEebgIHqNKAks5t7KWdgaJpZM4UhK18 .