Benjamin Gruenbaum comments

Results 784 comments of


                                            Benjamin Gruenbaum

[Feature]: In Node, hijack perf_hooks.performance in addition to global.performance

I think it's probably fine to support it and not a lot of work? I'm happy to make changes in Node if that'd help

Automating Flaky Test Detection

We track flaky tests in https://github.com/nodejs/reliability/

doc: note JavaScript is not single threaded

> To me, it would be better if we say that Node.js not JavaScript is single-thread. That's also not true (e.g. https://nodejs.org/api/worker_threads.html :D ). We can add Node.js executes a...

Update promise.props.md "typo fix"

This fix isn't correct though (language wise)

test_runner: add inline snapshot assertion

He's not (afaict) but he's not convinced that this feature as-is is useful enough and neither am I (given it's much worse dx than the userland alternatives that rewrite your...

lib: disable default memory leak warning for AbortSignal

@jasnell wdyt?

src: disable fast methods for `buffer.write`

@bricss please do not approve fast-track requests :] (or you know, start making PRs and join as a collaborator that also works :))

lib: ensure no holey array in fixed_queue

I'm approving this even without a test but a test would be nice

Skypack bundle cannot be loaded in the browser

@fatso83 nothing is stopping us from doing top-level `await import` right?

Additions to `import.meta`

> Are additions to import.meta semver-major or semver-minor? I think semver-minor is fine since unlike new globals I don't expect code to break when we add stuff to import.meta. >...