Benjamin Gruenbaum comments

Results 788 comments of


                                            Benjamin Gruenbaum

Nominating @MattiasBuelens as collaborator

Ping #2 @MattiasBuelens are you still interested? Did you reach out to @mcollina ?

net: support passing a host with port to Server.prototype.listen

This looks reasonable to me - @nodejs/http @nodejs/collaborators can this get some opinions/reviews?

Consider exposing promise unhandled rejection hook

@stefanpenner right, and I'm asking you expose it on "process" in addition like the proposal says, Please consider reading it :p

Consider exposing promise unhandled rejection hook

Awesome - thanks a ton :)

Consider exposing promise unhandled rejection hook

@stefanpenner The **whole idea** here is to is to fire the same events as native promises and with other libraries so you get a global place to handle every promise...

Consider exposing promise unhandled rejection hook

@vkurchatkin I believe there is, and several libraries have already implemented this. This standard is just a _minimal_ first stage as a preparation for more interesting standards and ideas which...

Consider exposing promise unhandled rejection hook

@stefanpenner there are no standards/language folks. This is just NodeJS/io.js and the libraries. The name `"possiblyUnhandledRejection"` doesn't make much sense outside of promises anyway so prefixing it doesn't make sense...

Consider exposing promise unhandled rejection hook

@stefanpenner note the events have been renamed to `unhandledRejection` and `unhandledRejectionHandled` as Domenic and Petka suggested in various threads and as when and bluebird implement.

Consider exposing promise unhandled rejection hook

@Domenic To be fair - Petka told me that you suggested these names in a spec and encourages implementing them with this name in bluebird as real events. If you...

Consider exposing promise unhandled rejection hook

I just want to mark the time and date - @domenic said something nice about bluebird :D (that it's popular)