Benjamin Gruenbaum comments

Results 788 comments of


                                            Benjamin Gruenbaum

Requiring a dynamically added dependency fails when the package has no `index.js` file

@matthewp Feel free to take my code from https://github.com/nodejs/node/pull/31921 and rebase it/copy it over the changed loader code. Happy to answer any questions about it.

Allow ArrayBuffer as argument to writeFile and friends

@nodejs/fs

Feature: Immutable Buffer `buffer.readonly()`

You can also define a proxy over the buffer though that would probably be expensive since it'd be hit on every access. I wonder if a proxy with only a...

Mocking import, import(), and require()

@nodejs/loaders @giltayar

Mocking import, import(), and require()

> Forking node, quitting my job, and moving into the woods to write a new JS platform with an extensible module system. Why does that sound so appealing 😅 Anyway...

Mocking import, import(), and require()

(You can also use other machinery like policies https://nodejs.org/api/policy.html#dependency-redirection to do this but this is "right up the alley" of loaders )

lib: performance improvement on readline async iterator

@Farenheith happy to help running the benchmarks it can be a bit tricky. They run code before/after a change and then perform a [statistical significance test](https://en.wikipedia.org/wiki/Student%27s_t-test) to verify the changes...

lib: performance improvement on readline async iterator

cc @mcollina you are currently request changes on this PTAL

lib: performance improvement on readline async iterator

> If I do that I could be introducing a new breaking change, though, so I'm not really sure about it Yes, let's not introduce any breaking changes (and I...

lib: performance improvement on readline async iterator

@ronag > Regarding on() I would prefer if we have a batched iterator helper. the changes here do not prevent that sort of extension? Note this mostly improves the performance...