Benjamin Gruenbaum
Benjamin Gruenbaum
> This is a great example to show that it’s not actually trivial, because Buffer.from(u8.buffer) works 95 % of the time, and will do the absolute wrong thing the other...
@paulmillr to address some of the comment status: > buffer.slice() is mutable copy, uint8array.slice() is immutable. This is very bad. Recently got hit with a bug report. I was checking...
(and similarly - this is very much an area Node could use more people involved and more contributions in!)
Big +1, valuable addition to the project both in terms of his technical contributions and his ability to drive change in big/meaningful features. I also worked with him before (in...
Hey, looks like this nomination has passed 🎉 @nodejs/tsc @aduh95
It's also possible to do: ``` Object.assign(Object.create(Foo), { .. }); ``` Although the version you have is shorter. It's also worth mentioning that although it requires transpilation in theory because...
@jinbeomhong that is not correct it was standardized in es2015
When I wrote that suggestion the deferring of a tick was intentional for clarity of code - but I don't have strong feelings about it.
@getify you're right :) I didn't know that would be the case when I first wrote that pump code. Another part of the fact it's wrapped in a `then` provides...
Pretty much, yeah, although then you can probably add a `Promise.resolve` on the `value` if the iterator is done and drop the `Promise.resolve` around everything.